[PATCH 1/8] ARM: shmobile: sh73a0 pinmux platform device cleanup

Simon Horman horms at verge.net.au
Tue Jun 4 01:20:43 EDT 2013


On Mon, May 27, 2013 at 09:02:43PM -0700, Olof Johansson wrote:
> On Mon, May 27, 2013 at 06:13:22PM +0400, Sergei Shtylyov wrote:
> > Hello.
> > 
> > On 27-05-2013 13:00, Simon Horman wrote:
> > 
> > >From: Magnus Damm <damm at opensource.se>
> > 
> > >Use DEFINE_RES_MEM() and platform_device_register_simple()
> > >to save a couple of lines of code.
> > 
> > >Signed-off-by: Magnus Damm <damm at opensource.se>
> > >Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > >Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
> > >---
> > >  arch/arm/mach-shmobile/setup-sh73a0.c |   25 ++++++-------------------
> > >  1 file changed, 6 insertions(+), 19 deletions(-)
> > 
> > >diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
> > >index fdf3894..f8f4261 100644
> > >--- a/arch/arm/mach-shmobile/setup-sh73a0.c
> > >+++ b/arch/arm/mach-shmobile/setup-sh73a0.c
> > >@@ -61,29 +61,16 @@ void __init sh73a0_map_io(void)
> > [...]
> > >+/* PFC */
> > >+static const struct resource pfc_resources[] = {
> > 
> >    Should have been annotated as __initdata... too late, need
> > another patch.
> 
> See comments on other patches/pull requests, I think there's time to revisit
> this. I.e. I'll hold off on pulling this based on the other feedback.

As I am respining I will fix this.

However, it had been reviewed and I think that ordinarily
it would be reasonable to perform further clean-up
work in a subsequent patch.



More information about the linux-arm-kernel mailing list