[PATCH v3 10/11] ARM: mmp: avoid to use cpu_is_xxx in timer

Haojian Zhuang haojian.zhuang at gmail.com
Mon Jun 3 21:24:48 EDT 2013


On Tue, Jun 4, 2013 at 6:34 AM, Arnd Bergmann <arnd at arndb.de> wrote:
> On Monday 03 June 2013, Haojian Zhuang wrote:
>>  void __init mmp_dt_init_timer(void)
>>  {
>>         struct device_node *np;
>> +       struct clk *clk;
>>         int irq, ret;
>> +       u32 rate = 0;
>>
>>         np = of_find_matching_node(NULL, mmp_timer_dt_ids);
>> -       if (!np) {
>> -               ret = -ENODEV;
>> -               goto out;
>
> Please use CLOCKSOURCE_OF_DECLARE() here and call clocksource_of_init()
> in the platform code, rather than calling mmp_dt_init_timer directly.
>
>         Arnd

CLOCKSOURCE_OF_DECLARE() is in the 11th patch. And mmp_dt_init_timer()
won't be called in 11th patch.

I split it into 10th & 11th. Since I just want 10th patch to remove
cpu_is_xxx().

Regards
Haojian



More information about the linux-arm-kernel mailing list