[PATCH] clocksource: armada-xp: always register local_timer_ops

Stephen Boyd sboyd at codeaurora.org
Mon Jun 3 21:04:05 EDT 2013

On 06/04, Arnd Bergmann wrote:
> The call to local_timer_register is hidden behind an #ifdef, which
> turns the armada_370_xp_local_timer_ops into a potentially unused
> variable, causing this warning:
> time-armada-370-xp.c:208:31: warning: 'armada_370_xp_local_timer_ops' defined but not used [-Wunused-variable]
>  static struct local_timer_ops armada_370_xp_local_timer_ops __cpuinitdata = {
>                                ^
> Since local_timer_register() itself doesn't do anything, just removing
> the #ifdef makes the code look nicer and gets rid of the warning.
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> Cc: Gregory CLEMENT <gregory.clement at free-electrons.com>
> Cc: Jason Cooper <jason at lakedaemon.net>
> ---
> Please apply for 3.11

This will conflict slightly with my series[1]. If this is targeted
for 3.11 it may be better to just drop this patch and let my
series remove the ops structure entirely.

[1] https://lkml.org/lkml/2013/6/3/583

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

More information about the linux-arm-kernel mailing list