[PATCH v3 07/11] ARM: mmp: move timer registers into driver

Arnd Bergmann arnd at arndb.de
Mon Jun 3 18:31:31 EDT 2013


On Monday 03 June 2013, Haojian Zhuang wrote:
>  void __init timer_init(int irq)
>  {
> +       mmp_timer_base = ioremap(TIMERS_PHY_BASE, PAGE_SIZE);
> +       BUG_ON(!mmp_timer_base);
> +

Here I would pass TIMERS_PHY_BASE as another argument, and move the
definition of that macro back into platform code. Device drivers should
be written not to care about physical addresses.

	Arnd



More information about the linux-arm-kernel mailing list