[PATCH v3 04/11] ARM: mmp: avoid to include head file in mach-mmp

Arnd Bergmann arnd at arndb.de
Mon Jun 3 18:28:53 EDT 2013


On Monday 03 June 2013, Haojian Zhuang wrote:
> +extern struct irq_chip icu_irq_chip;
>  void __init mmp2_init_irq(void)
>  {
>         mmp2_init_icu();
> +       icu_irq_chip.irq_set_wake = mmp2_set_wake;
>  }
>  

I think it's better to put the declaration into a header file in
include/linux/irqchip/. Extern declarations in .c files are always
fragile.

	Arnd



More information about the linux-arm-kernel mailing list