[PATCH] ARM: mxs: icoll: Fix interrupts gpio bank 0

Shawn Guo shawn.guo at linaro.org
Mon Jun 3 11:15:32 EDT 2013


On Wed, May 29, 2013 at 10:42:58PM +0800, Shawn Guo wrote:
> On Tue, May 28, 2013 at 05:00:57PM +0200, Markus Pargmann wrote:
> > The mxs interrupt controller does not support polling for interrupts,
> > but the driver still does it, which is a relict from
> > pre-MULTI_IRQ_HANDLER times.
> > 
> > The existing code assumes that 0x7f means no interrupt, but this value
> > is an actually valid irq number, namely gpio bank 0's irq. This results
> > in the driver not detecting when irq 0x7f is active which makes the
> > machine effectively dead lock.
> > 
> > This patch removes the interrupt poll loop and allows usage of gpio0
> > interrupt without an infinite loop.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > Signed-off-by: Markus Pargmann <mpa at pengutronix.de>
> > Cc: stable at vger.kernel.org
> 
> Thomas, can you please help handle the fix?  If yes, here is my ack.
> 
> Acked-by: Shawn Guo <shawn.guo at linaro.org>
> 
> Otherwise, I can send it through arm-soc tree if you're fine with it.

Thomas,

I'm sending the fix through arm-soc, and let me know if you have problem
with that.

Shawn




More information about the linux-arm-kernel mailing list