[PATCH V2 3/6] ARM: tegra: make tegra_resume can work for Tegra114
Arnd Bergmann
arnd at arndb.de
Sat Jun 1 05:47:30 EDT 2013
On Saturday 01 June 2013, Stephen Warren wrote:
> On 05/31/2013 04:41 PM, Arnd Bergmann wrote:
> > On Monday 20 May 2013, Joseph Lo wrote:
> >> + cpu_to_csr_req r1, r0
> >> + mov32 r2, TEGRA_FLOW_CTRL_BASE
> >> + ldr r1, [r2, r1]
> >
> > This causes build errors now, since cpu_to_csr_req is not defined anywhere.
>
> What build error are you seeing? I built next-20130531 earlier today
> without any issue.
>
> I do remember making a similar comment during review of this patch that
> cpu_to_csr_req wasn't defined anywhere, but IIRC Joseph pointed me to
> another patch in the series which had added it, or something like that.
Sorry, I should have mentioned it was using randconfig, all the defconfig
builds work fine. The code is inside of "#ifndef CONFIG_ARCH_TEGRA_2x_SOC",
but Tegra2 is normally enabled in defconfig, so it does not get built.
I suspect the #ifdef is wrong as well, and should have been "if tegra3
or tegra4" instead. Joseph, can you clarify the intent of this?
Arnd
More information about the linux-arm-kernel
mailing list