[PATCH RESEND] clk: export __clk_get_flags for modular clock providers
Mike Turquette
mturquette at linaro.org
Tue Jul 30 19:03:24 EDT 2013
Quoting Luciano Coelho (2013-07-04 13:45:27)
> Hi,
>
> On 04/15/2013 09:59 AM, Sebastian Hesselbarth wrote:
> > The common clock api provides some helpers for clk-providers but does
> > not export these helpers. This hinders clk-providers to be built as modules.
> > This patch adds __clk_get_flags() to the list of exported symbols.
> >
> > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com>
> > ---
> > Cc: Mike Turquette <mturquette at linaro.org>
> > Cc: linux-arm-kernel at lists.infradead.org
> > Cc: linux-kernel at vger.kernel.org
> > ---
> > drivers/clk/clk.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > index ed87b24..3e478b8 100644
> > --- a/drivers/clk/clk.c
> > +++ b/drivers/clk/clk.c
> > @@ -450,6 +450,7 @@ unsigned long __clk_get_flags(struct clk *clk)
> > {
> > return !clk ? 0 : clk->flags;
> > }
> > +EXPORT_SYMBOL_GPL(__clk_get_flags);
> >
> > bool __clk_is_enabled(struct clk *clk)
> > {
> >
>
> I think this got merged slightly wrong. The EXPORT_SYMBOL_GPL macro
> came under clk_unprepare_unused_subtree() instead of under
> __clk_get_flags():
>
>
> Of course this is not that important, but it's a bit confusing when you
> look at the code.
Thanks for pointing this out. I've fixed it up.
Regards,
Mike
>
> --
> Cheers,
> Luca.
More information about the linux-arm-kernel
mailing list