[PATCH] ARM(64): KVM: add signed type cast for comparation
Chen Gang
gang.chen at asianux.com
Mon Jul 29 22:51:47 EDT 2013
Hello Maintainers:
Please help check the patch whether OK or not, when you have time.
Thanks.
On 07/22/2013 11:20 AM, Chen Gang wrote:
> 'len' is 'unsigned long' which is never less than zero.
>
> So need a related type cast for comparation.
>
> The related warning (when building ARM64 with allmodconfig):
>
> arch/arm64/kvm/../../../arch/arm/kvm/mmio.c:82:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
>
>
> Signed-off-by: Chen Gang <gang.chen at asianux.com>
> ---
> arch/arm/kvm/mmio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/kvm/mmio.c b/arch/arm/kvm/mmio.c
> index b8e06b7..626dfc8 100644
> --- a/arch/arm/kvm/mmio.c
> +++ b/arch/arm/kvm/mmio.c
> @@ -79,7 +79,7 @@ static int decode_hsr(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa,
> }
>
> len = kvm_vcpu_dabt_get_as(vcpu);
> - if (unlikely(len < 0))
> + if (unlikely((long)len < 0))
> return len;
>
> is_write = kvm_vcpu_dabt_iswrite(vcpu);
>
--
Chen Gang
More information about the linux-arm-kernel
mailing list