[PATCH 1/3] pinctrl: rollback check for !dev->pins in pinctrl_pm_select*() APIs

Linus Walleij linus.walleij at linaro.org
Fri Jul 26 19:22:37 EDT 2013


On Wed, Jul 17, 2013 at 5:40 PM, Tony Lindgren <tony at atomide.com> wrote:
> * Grygorii Strashko <grygorii.strashko at ti.com> [130717 04:49]:
>> The pinctrl support in Device core assumed to be optional - so, It's
>> valid case, when there are no definition for default device's pinctrl
>> states in DT at all ("default", "active", "idle", "sleep").
>> And in this case dev->pins == NULL and pinctrl_pm_select*() API
>> should return 0 always.
>>
>> Now the checks for !dev->pins have been removed from
>> pinctrl_pm_select*() API mistakenly by the patch
>> pinctrl: Remove duplicate code in pinctrl_pm_select_state functions
>> http://www.spinics.net/lists/arm-kernel/msg258829.html
>>
>> Hence, rollback these checks in in pinctrl_pm_select*() APIs.
>
> Thanks, it's best that I fold this fix into my patch as it has not
> been committed yet.

I think I've applied the correct v2 version,
please check that linux-next is in good shape...

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list