[PATCH 2/2] clk: fixup argument order when setting VCO parameters

Mike Turquette mturquette at linaro.org
Thu Jul 25 13:44:16 EDT 2013


Quoting Jonathan Austin (2013-07-25 02:30:29)
> On 24/07/13 20:32, Linus Walleij wrote:
> > On Tue, Jul 23, 2013 at 5:42 PM, Jonathan Austin
> > <jonathan.austin at arm.com> wrote:
> >
> >> The order of arguments in the call to vco_set() for the ICST clocks appears to
> >> have been switched in error, which results in the VCO not being initialised
> >> correctly. This in turn stops the integrated LCD on things like Integrator/CP
> >> from working correctly.
> >>
> >> This patch fixes the order and restores the expected functionality.
> >>
> >> Cc: Linus Walleij <linus.walleij at linaro.org>
> >> Cc: Mike Turquette <mturquette at linaro.org>
> >> Signed-off-by: Jonathan Austin <jonathan.austin at arm.com>
> >
> > Good catch! Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
> > You should probably mark this for stable as well.
> >
> 
> Mike, will you add Cc: stable when you take the fix or shall I resubmit 
> the patch somehow else?

I'll add it.

Regards,
Mike



More information about the linux-arm-kernel mailing list