[PATCH 1/2] i2c: davinci: remove useless mach/hardware include

Sekhar Nori nsekhar at ti.com
Thu Jul 25 05:40:19 EDT 2013


On Thursday 25 July 2013 05:58 AM, Santosh Shilimkar wrote:
> This driver no longer uses definitions from mach/hardware.h.
> On the other hand, including this header breaks this driver
> on non-davinci platforms which don't have such a header.
> 
> Fix it.
> 
> Cc: Sekhar Nori <nsekhar at ti.com>
> Cc: Wolfram Sang <wsa at the-dreams.de>
> 
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar at ti.com>

Acked-by: Sekhar Nori <nsekhar at ti.com>

One minor nit:

> ---
>  drivers/i2c/busses/i2c-davinci.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index fa55605..ddaa2a3 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -41,7 +41,6 @@
>  #include <linux/of_i2c.h>
>  #include <linux/of_device.h>
>  

You can now remove this empty line too.

Thanks,
Sekhar

> -#include <mach/hardware.h>
>  #include <linux/platform_data/i2c-davinci.h>
>  
>  /* ----- global defines ----------------------------------------------- */
> 




More information about the linux-arm-kernel mailing list