[PATCH 2/2] clk: fixup argument order when setting VCO parameters

Linus Walleij linus.walleij at linaro.org
Wed Jul 24 15:32:54 EDT 2013


On Tue, Jul 23, 2013 at 5:42 PM, Jonathan Austin
<jonathan.austin at arm.com> wrote:

> The order of arguments in the call to vco_set() for the ICST clocks appears to
> have been switched in error, which results in the VCO not being initialised
> correctly. This in turn stops the integrated LCD on things like Integrator/CP
> from working correctly.
>
> This patch fixes the order and restores the expected functionality.
>
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Cc: Mike Turquette <mturquette at linaro.org>
> Signed-off-by: Jonathan Austin <jonathan.austin at arm.com>

Good catch! Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
You should probably mark this for stable as well.

What I don't understand is why my CLCD VGA output has
been working all the time :-(

I thought this VCO was necessary for that as well,  but apparently
it works with the defaults.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list