[PATCH] bcm53xx: initial support for the BCM5301/BCM470X SoC with ARM CPU
Arend van Spriel
arend at broadcom.com
Tue Jul 23 15:14:49 EDT 2013
On 07/23/2013 08:56 PM, Florian Fainelli wrote:
> If you want to add more confusion, because there is,
> drivers/staging/bcm which stands for Beceem has been later acquired by
> Broadcom, eventually turning this 3 letter word into something
> "consistent" from a Broadcom point of view. As far as I am concerned,
> I would just stick with the allocated vendor prefix and replace "bcm"
> with "brcm" because the allocated one is the authoritative one.
Nice, huh. In device-tree notation it identifies the vendor and I agree
that brcm is a better/preferred vendor id. The confusion here is that
the device identifiers are all prefixed with "bcm", which is something
different than the vendor id. I do not think consistency was the goal in
the acquisition of Beceem ;-)
>>> >>the bcm281x/kona family support code be merged and use "bcm" there, without
>>> >>registering it. Besides, a simple rule of number here wins:
>>> >>git grep "brcm," * | wc -l
>>> >>git grep "bcm," * | wc -l
>>> >>(as of Linux 3.11-rc1)
>>> >>So consistency we should get the bcm281x/kona DT bindings to rename their
>>> >>vendor prefix as well.
>> >I believe getting this "right" is far more important than the difference
>> >in churn of a mere 38 instances of use of brcm. "Right" is two things:
>> >1) it needs to be consistent 2) it should be what makes sense.
> I agree, which is the reason why I would stick with the vendor prefix
> and end the story there.
More information about the linux-arm-kernel