[PATCH] bcm53xx: initial support for the BCM5301/BCM470X SoC with ARM CPU

Matt Porter matt.porter at linaro.org
Tue Jul 23 14:49:08 EDT 2013

On Wed, Jul 17, 2013 at 12:08:30AM +0100, Florian Fainelli wrote:
> Hello,
> Le mardi 16 juillet 2013 11:14:36 Matt Porter a écrit :
> > > +	compatible = "brcm,bcm5301x";
> > 
> > Ok, this was nagging at me before I went on my very long vacation. I see
> > the "brcm" vendor prefix as a real consistency problem. I noticed on the
> > bcm281xx/kona family, we have been using "bcm" which is not logged in
> > vendor-prefixes.txt as a legitimate prefix. I see that bcm2835 had
> > already established use of "brcm" before any of the bcm281xx support
> > came in. Ideally, the vendor prefix should change to "bcm" since every
> > reference in the family names is BCM. However, if others want the least
> > amount of churn in making this consistent, we might have to go with
> > "brcm" across the board.
> I would like to keep "brcm" here because that is what has been defined as a 
> vendor prefix, and is used beyond the scope of the ARM Linux kernel support 
> even within Broadcom. Maybe it was an oversight, or rather a mistake to let 

[Update: I thought some more about this and investigated why Broadcom started
 using "bcm" and changed my mind]

Can you provide a cite? I can tell you that within Broadcom they have
been moving to get rid of it. That is why you see all this Broadcom
originated code using "bcm" because it actually matches their part
number prefix. As further evidence of the preference for "bcm", feel free to
look through the entire public catalog of parts at
http://www.broadcom.com/products/ and note that they all have BCM as the part
prefix...this carries over into all driver references to the parts as well
including everything in the wireless world.

> the bcm281x/kona family support code be merged and use "bcm" there, without 
> registering it. Besides, a simple rule of number here wins:
> git grep "brcm," * | wc -l
> 63
> git grep "bcm," * | wc -l
> 25
> (as of Linux 3.11-rc1)
> So consistency we should get the bcm281x/kona DT bindings to rename their 
> vendor prefix as well.

I believe getting this "right" is far more important than the difference
in churn of a mere 38 instances of use of brcm. "Right" is two things:
1) it needs to be consistent 2) it should be what makes sense.


More information about the linux-arm-kernel mailing list