[RFC v2] ARM: i.MX pllv1: Implement set_rate

[Alexander Shiyan]

On Sat, 20 Jul 2013 13:16:39 +0200
Sascha Hauer <s.hauer at pengutronix.de> wrote:

> On Sat, Jul 20, 2013 at 12:29:35PM +0400, Alexander Shiyan wrote:
> > This patch implements frequency change for i.MX pllv1.
> > Selection of the values of the registers is not optimal, since is
> > made by simple enumeration of all possible values.
> 
> You do not mention why you want to adjust the rate. Normally we've been
> happy with the static values from the bootloader.

For CPUfreq.
Only one barrier to make it workable.

[...]
> > +	/* Avoid i.MX27 TO2 SPCTL0 bug */
> > +	if (cpu_is_mx27() && (mx27_revision() == IMX_CHIP_REVISION_2_0))
> > +		writel(reg, pll->base);
> 
> I remember this was fixed and got lost. If you want to have fixed it
> again this should be a separate paatch along with a description of the
> bug in the commit log.

This part of the patch can be completely removed ;)
I'm more interested in a more efficient algorithm for finding the best
values for the PLL.

[...]

-- 
Alexander Shiyan <shc_work at mail.ru>