[PATCH 1/3] ARM: shmobile: use common platform header for HPB-DMAC
sergei.shtylyov at cogentembedded.com
Fri Jul 19 07:32:38 EDT 2013
On 19-07-2013 15:17, Sergei Shtylyov wrote:
>>>>> From: Max Filippov <max.filippov at cogentembedded.com>
>>>>> Use previously empty <mach/dma.h> to declare HPB-DMA slave IDs.
>>>>> Signed-off-by: Max Filippov <max.filippov at cogentembedded.com>
>>>>> [Sergei: changed the guard macro name, fixed comment, extended copyright.]
>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
>>>>> arch/arm/mach-shmobile/include/mach/dma.h | 25
>>>>> 1 file changed, 24 insertions(+), 1 deletion(-)
>>>> Thanks for your patch. Can you please explain the reason why you put
>>>> this shared information under mach/?
IIUC, because the only 2 file using it were under arch/arm/mach-shmobile/.
>>> I'm afraid that's more a question to the original author, Phil Edworthy.
>>> He put this stuff into <mach/hpb-dmae.h>.
>> Then, why you could send this patch instead of original author,
> Ask Phil why didn't he upstream his stuff. We, unlike him, do have
> obligation to upstream it.
>> even though you can't answer any question about it ?
> I'm not the author of the patch, let me remind you, Max Filippov is.
> He was on vacations.
Phil's patches were only for R8A7778, IIRC (yet, the platfrom DMA code was
placed in a separate file, not r8a7778.c). Max decided to use the
<mach/hpb-dmae.h> header for sharing the DMA channel IDs between R8A777, I
agreed but suggested to use the empty <mach/dma.h> instead.
>> Best regards
>> Kuninori Morimoto
More information about the linux-arm-kernel