[PATCH] ARM: locks: remove opencoded #16 for ticket shift

Will Deacon will.deacon at arm.com
Fri Jul 19 05:05:03 EDT 2013


On Thu, Jul 18, 2013 at 06:53:06PM +0100, Nicolas Pitre wrote:
> On Thu, 18 Jul 2013, Will Deacon wrote:
> > There are two aspects to the ticket lock:
> > 
> >   1. The size of each ticket
> >   2. The location of the next ticket within the 32-bit lock word
> > 
> > TICKET_SHIFT actually defines (2) and could be 0 or 16, hence why I was
> > making this small cosmetic change.
> 
> Doesn't matter where the location of the next ticket is.  Whether it is 
> 0 or 16, for the above code to work, it *must* always perform a ror #16.  
> Hence tying the ror constant with TICKET_SHIFT is wrong.

You're right; we always need to refer to the higher ticket, rather than
`owner' or `next'. Patch dropped.

Cheers,

Will



More information about the linux-arm-kernel mailing list