[PATCH 2/3] drivers: gpio: msm: Fix the error condition for reading ngpio

David Brown davidb at codeaurora.org
Thu Jul 18 16:07:14 EDT 2013


From: Rohit Vaswani <rvaswani at codeaurora.org>

of_property_read_u32 return 0 on success. The check was using a ! to
return error. Fix the if condition.

Signed-off-by: Rohit Vaswani <rvaswani at codeaurora.org>
Acked-by: Linus Walleij <linus.walleij at linaro.org>
Reviewed-by: Pankaj Jangra  <jangra.pankaj9 at gmail.com>
Cc: "Bird, Tim" <Tim.Bird at sonymobile.com>
Signed-off-by: David Brown <davidb at codeaurora.org>
---
 drivers/gpio/gpio-msm-v2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-msm-v2.c b/drivers/gpio/gpio-msm-v2.c
index f4491a4..c2fa770 100644
--- a/drivers/gpio/gpio-msm-v2.c
+++ b/drivers/gpio/gpio-msm-v2.c
@@ -378,7 +378,7 @@ static int msm_gpio_probe(struct platform_device *pdev)
 	int ret, ngpio;
 	struct resource *res;
 
-	if (!of_property_read_u32(pdev->dev.of_node, "ngpio", &ngpio)) {
+	if (of_property_read_u32(pdev->dev.of_node, "ngpio", &ngpio)) {
 		dev_err(&pdev->dev, "%s: ngpio property missing\n", __func__);
 		return -EINVAL;
 	}
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation




More information about the linux-arm-kernel mailing list