[PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system
Nicolas Pitre
nicolas.pitre at linaro.org
Wed Jul 17 18:34:11 EDT 2013
On Wed, 17 Jul 2013, Stephen Boyd wrote:
> On 07/12/13 05:10, Stephen Boyd wrote:
> > On 07/12, Javi Merino wrote:
> >> I agree, we should drop the check. It's annoying in uniprocessors and
> >> unlikely to be found in the real world unless your gic entry in the dt
> >> is wrong.
And that's a likely outcome in the real world.
> >>
> > Ok. How about this?
>
> Any comments?
What about this instead:
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 19ceaa60e0..86d21bc6cb 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -368,7 +368,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)
break;
}
- if (!mask)
+ if (is_smp() && !mask)
pr_crit("GIC CPU mask not found - kernel will fail to boot.\n");
return mask;
Nicolas
More information about the linux-arm-kernel
mailing list