[PATCH] arm, kbuild: make "make install" not depend on vmlinux
rric at kernel.org
Wed Jul 17 12:57:43 EDT 2013
On 17.07.13 09:36:57, Linus Torvalds wrote:
> On Wed, Jul 17, 2013 at 9:05 AM, Robert Richter <rric at kernel.org> wrote:
> > I narrowed this down. The problem is that zinstall on ARCH=arm has a
> > dependency to vmlinux which does a prepare/prepare3 and finally does a
> > forced rebuild of kernel.release even if it exists already.
> > Rebuilding it removes kernel.release first and then recreates it. This
> > might race with another parallel make job running depmod.
> > So on arm and maybe other archs we need the same as for x86:
> > 1648e4f8 x86, kbuild: make "make install" not depend on vmlinux
> > The patch below fixes this for arm. It is build-tested in my
> > environment, but please test it in others too if possible.
> Ack. This looks like the right thing to do.
Thanks for looking at this.
> That said, I think for clarity you might perhaps want to make the
> unrelated change of adding double quotes around $(KERNELRELEASE) a
> separate patch. Not a big deal, but it took me a moment to say "why
> did he do that" (in fact, I'm not sure KERNEL_RELEASE can actually
> validly have spaces in it, but quoting it is certainly not wrong
> either - but it might be unnecessary.
If kernel.release doen't exist KERNEL_RELEASE is empty, thus all args
for install.sh shift one arg left. Putting it in quotes avoids this.
Noticed this since the first verified file in install.sh ($2) should
be the image file but was already System.map ($3).
Will splitt the patches and resend.
More information about the linux-arm-kernel