[PATCH 4/5] iio: at91: add an optional dt property for for adc clock hz.

Lars-Peter Clausen lars at metafoo.de
Tue Jul 16 07:16:43 EDT 2013


On 07/16/2013 12:30 PM, Maxime Ripard wrote:
[...]
>> After a further thinking of this, maybe remove the adc_op_clk is
>> better since it is a fake clock, and only used to specify the clock
>> rate.
>> To specify the clock rate use a dt property or platform data
>> parameter is better.
> 
> No, to specify *any* clock, the common clock framework is the better
> solution.

Yep, this patch is not the right approach. It's trying to work around the
limitations of the platforms clock API implementation. Please fix the at91
clock implementation instead (e.g. by switching to the common clock framework).

- Lars




More information about the linux-arm-kernel mailing list