[PATCH 2/3] serial: mxs: enable the DMA only when the rts/cts is enabled

Huang Shijie b32955 at freescale.com
Tue Jul 16 04:11:19 EDT 2013


于 2013年07月16日 15:33, Uwe Kleine-König 写道:
>> This patch depends on the first patch. :)
> But it's not a hard dependency.
>
do you mean i should merge the patch 1 and patch 2 into a single patch?

>>> Something like:
>>>
>>> 	serial: mxs-auart: DMA unreliable without RTS/CTS
>>>
>>> 	According to [add some document name here] DMA doesn't work
>>> 	reliable without hardware handshaking. So make DMA dependant on
>>>   
>> Please see the spec about the RTSEN and RTS.
> Right, it's not hard for me. Other might not have the manual handy, so
> a comment telling:
>
>> RTSEN enable the flow control by the hardware;
>> RTS enable the flow control by the software.
> would be nice.
i think we need another patch to add this comment.

thanks
Huang Shijie




More information about the linux-arm-kernel mailing list