[PATCH 1/6] clk: exynos4: Staticize local symbols

Kukjin Kim kgene.kim at samsung.com
Tue Jul 16 03:34:23 EDT 2013


Sachin Kamat wrote:
> 
> Symbols referenced only in this file are made static.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
> ---
>  drivers/clk/samsung/clk-exynos4.c |   30 ++++++++++++++++--------------
>  1 file changed, 16 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-
> exynos4.c
> index 1bdb882..18eadc4 100644
> --- a/drivers/clk/samsung/clk-exynos4.c
> +++ b/drivers/clk/samsung/clk-exynos4.c

[...]

> @@ -975,7 +975,7 @@ static void __init
> exynos4_clk_register_finpll(unsigned long xom)
>   * clock speed.
>   */
>  void __init exynos4_clk_register_fixed_ext(unsigned long xxti_f,
> -						unsigned long xusbxti_f)
> +						  unsigned long xusbxti_f)

Why?

>  {
>  	exynos4_fixed_rate_ext_clks[0].fixed_rate = xxti_f;
>  	exynos4_fixed_rate_ext_clks[1].fixed_rate = xusbxti_f;
> @@ -990,7 +990,9 @@ static __initdata struct of_device_id ext_clk_match[]
> = {
>  };
> 
>  /* register exynos4 clocks */
> -void __init exynos4_clk_init(struct device_node *np, enum exynos4_soc
> exynos4_soc, void __iomem *reg_base, unsigned long xom)
> +static void __init exynos4_clk_init(struct device_node *np,
> +				    enum exynos4_soc exynos4_soc,
> +				    void __iomem *reg_base, unsigned long
xom)
>  {
>  	struct clk *apll, *mpll, *epll, *vpll;
> 
> --
> 1.7.9.5

And don't we need following?

diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
index 3e156bc..3a34f1e 100644
--- a/arch/arm/mach-exynos/common.h
+++ b/arch/arm/mach-exynos/common.h
@@ -26,7 +26,6 @@ void exynos5_restart(enum reboot_mode mode, const char
*cmd);
 void exynos_init_late(void);

 /* ToDo: remove these after migrating legacy exynos4 platforms to dt */
-void exynos4_clk_init(struct device_node *np, int is_exynos4210, void
__iomem *reg_base, unsigned long xom);
 void exynos4_clk_register_fixed_ext(unsigned long, unsigned long);

 void exynos_firmware_init(void);

- Kukjin




More information about the linux-arm-kernel mailing list