[PATCH v7 3/9] iommu/exynos: fix page table maintenance

Grant Grundler grundler at chromium.org
Mon Jul 15 12:18:41 EDT 2013


On Mon, Jul 15, 2013 at 4:21 AM, Cho KyongHo <pullip.cho at samsung.com> wrote:
...
>> Maybe you could add LV1TABLE_SIZE define and use it here (there is
>> already a LV2TABLE_SIZE define)?
>
> Yes. But, LV2TABLE_SIZE is used in more places than one.
> I do not feel that it is needed to define LV1TABLE_SIZE for the single line.

Cho,
#define's are part of the code "documentation". Doesn't really matter
how often it's used. I think Bartlomiej's suggestion is a good one.

Key is to use "consistent" names so they makes sense to someone not
familiar with the code. In this case, we want to show this use is the
same way LV2TABLE_SIZE is used and serves the same purpose.

cheers.
grant



More information about the linux-arm-kernel mailing list