[PATCH v3 2/2] iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver
Lars-Peter Clausen
lars at metafoo.de
Mon Jul 15 07:33:53 EDT 2013
On 07/15/2013 01:09 PM, Kozaruk, Oleksandr wrote:
[...]
>
>>> + ret = devm_request_threaded_irq(dev, irq, NULL,
>>> + twl6030_gpadc_irq_handler,
>>> + IRQF_ONESHOT, "twl6030_gpadc", gpadc);
>>
>> You access memory in the interrupt handler which is freed before the interrupt
>> handler is freed.
> Thanks for pointing this. devm_* will free memory for irq after the driver
> is removed and memory for the device is freed. I took me awhile to understand
> this. Is there going to be something like devm_iio_device_alloc? whould it be helpfull?
>
Yes, I think it certainly makes sense to add a devm_iio_device_alloc(), care
to send a patch?
More information about the linux-arm-kernel
mailing list