[PATCH] ARM: omap2: add select of TI_PRIV_EDMA

Arnd Bergmann arnd at arndb.de
Wed Jul 10 10:36:57 EDT 2013


On Wednesday 10 July 2013, Sekhar Nori wrote:
> On 7/10/2013 1:20 PM, Tony Lindgren wrote:
> > * Olof Johansson <olof at lixom.net> [130709 01:44]:
> >> "ARM: OMAP: build mach-omap code only if needed" moved around the
> >> ARCH_OMAP2PLUS stanza, but accidentally dropped the seleciton of
> >> TI_PRIV_EDMA in the process. Add it back.
> >>
> >> Cc: Arnd Bergmann <arnd at arndb.de>
> > 
> > Acked-by: Tony Lindgren <tony at atomide.com>
> > 
> >> Signed-off-by: Olof Johansson <olof at lixom.net>
> 
> Thinking more, I do not think we should be selecting TI_PRIV_EDMA for
> OMAP2PLUS. There is no part of mach-omap2 that depends directly on
> TI_PRIV_EDMA being enabled.
> 
> Instead, TI_PRIV_EDMA should be selected by the DMA engine driver as
> done in the patch here:
> 
> http://www.spinics.net/lists/kernel/msg1563777.html
> 
> Its the DMA engine driver which makes the private DMA calls so this
> patch is better.

I would have done 'depends on TI_PRIV_EDMA' instead, but any of the three
solutions is fine with me.

	Arnd



More information about the linux-arm-kernel mailing list