[v3 3/3] sata: imx: add ahci sata support on imx platforms
r65037 at freescale.com
Fri Jul 5 21:55:19 EDT 2013
Thanks for your comments.
From: Alexander Shiyan [shc_work at mail.ru]
Sent: Saturday, July 06, 2013 12:06 AM
To: Sascha Hauer
Cc: Richard Zhu; Zhu Richard-R65037; shawn.guo at linaro.org; rob.herring at calxeda.com; linux-ide at vger.kernel.org; avorontsov at ru.mvista.com; jgarzik at pobox.com; linux-arm-kernel at lists.infradead.org
Subject: Re: [v3 3/3] sata: imx: add ahci sata support on imx platforms
> On Fri, Jul 05, 2013 at 05:52:22PM +0800, Richard Zhu wrote:
> > From: Richard Zhu <r65037 at freescale.com>
> > + if (!(ret & HOST_CAP_SSS))
> > + writel(ret |= HOST_CAP_SSS, mmio + HOST_CAP);
> Why do you write this conditionally? Just write it unconditionally.
"writel" with assignment is incorrect in any case.
[Richard] would be fixed later.
More information about the linux-arm-kernel