hrtimer: one more expiry time overflow check in hrtimer_interrupt
Shinya Kuribayashi
shinya.kuribayashi.px at renesas.com
Fri Jul 5 07:50:24 EDT 2013
On 6/28/2013 9:22 PM, Thomas Gleixner wrote:
>> On the other hand, we have another call site of tick_program_event() at
>> the bottom of hrtimer_interrupt(). The warning this time is triggered
>> there, so we need to apply the same fix to it.
>
> Well, the problem is that you are just papering over the underlying
> issue of 32bit systems not being prepared for the year 2038 issue.
>
> Just blindly silencing the warning is not going to make the system
> survive 2038 in any sane way. All timespec/val related time functions
> dealing with the clock realtime domain are simply broken in 2038 on
> 32bit, so it does not matter whether a warning triggers or not.
You're right. With this patch applied, the hrtimer_interrupt /looks/
back to normal, but /proc/timer_list still show that "expires at [in
negative range]":
active timers:
#0: tick_cpu_sched, tick_sched_timer, S:01
# expires at 50812500000-50812500000 nsecs [in -165398341280 to -165398341280 nsecs]
This shouldn't happen and something weird is still going on.
> We really need to tackle the underlying problem and not bandaiding a
> known to be broken system.
Agreed, but a little bit hard task for me. This is 100% reproducible,
so I can help debug / verification. Please let me know, if necessary.
Thanks for your comments,
--
Shinya Kuribayashi
Renesas Electronics
More information about the linux-arm-kernel
mailing list