OMAP baseline test results for v3.10-rc6

[Paul Walmsley]

On Tue, 2 Jul 2013, Nishanth Menon wrote:

> On 07/01/2013 11:29 PM, Hiremath, Vaibhav wrote:
> > 
> > > -----Original Message-----
> > > From: Paul Walmsley [mailto:paul at pwsan.com]
> > > Sent: Monday, July 01, 2013 7:46 AM
> > > To: Vutla, Lokesh
> > > Cc: Nayak, Rajendra; Hiremath, Vaibhav; Kevin Hilman; Rini, Tom; linux-
> > > omap at vger.kernel.org; Balbi, Felipe; linux-arm-
> > > kernel at lists.infradead.org
> > > Subject: Re: OMAP baseline test results for v3.10-rc6
> > > 
> > > On Fri, 28 Jun 2013, Paul Walmsley wrote:
> > > 
> > > > On Thu, 27 Jun 2013, Lokesh Vutla wrote:
> > > > 
> > > > > Here is the catch..
> > > > > Your dtb is generated in arch/arm/boot/dts/ folder(before V3.8 dtb
> > > was
> > > > > generated in arch/arm/boot).
> > > > 
> > > > Ugh... that's probably it :-(
> to prevent this from happening again, Lokesh did post a patch:
> https://patchwork.kernel.org/patch/2796921/
> 
> Will be good to ack it if we think it might prevent such scenarios in the
> future.

Thanks for the suggestion.  

Unfortunately it wouldn't have caught the problem, since, as I mentioned 
in the E-mail you quoted, I build from a fresh tree each time.  So there 
was no previous DTB.  This wasn't caught here because 'cat' was copying 
over the kernel to its standard output, even though it was returning an 
error, and I wasn't checking the 'cat' return value.  This is obviously 
being remedied here.

Also will modify the build scripts to output each command as it's being 
run.

As far as Lokesh's patch goes: it doesn't make sense to me to remove a 
file during 'make clean' that the build process doesn't create.  So while 
I understand the motivation for the patch, and don't mind if upstream 
takes it, I personally wouldn't care to ack it.


- Paul