[PATCH V2] ARM: add missing __FINIT to head-common.S to match __INIT
Stephen Warren
swarren at wwwdotorg.org
Wed Jul 3 14:12:54 EDT 2013
From: Stephen Warren <swarren at nvidia.com>
Macro __INIT is used to place various code in head-common.S into the init
section. This should be matched by a closing __FINIT at the end of the
code destined for the init section. Add this missing macro.
This historically caused no problem, because macro __CPUINIT was used at
the exact location where __FINIT was missing, which then placed following
code into the cpuinit section. However, with commit 22f0a2736 "init.h:
remove __cpuinit sections from the kernel" applied, __CPUINIT becomes a
no-op, thus leaving all this code in the init section, rather than the
regular text section. This caused issues such as secondary CPU boot
failures or crashes.
Signed-off-by: Stephen Warren <swarren at nvidia.com>
Acked-by: Paul Gortmaker <paul.gortmaker at windriver.com>
---
v2: Moved __FINIT after lookup_processor_type, to correctly match the
location of __CPUINIT.
Russell, I assume I should add this to the ARM patch tracker.
This version is based on v3.10.
---
arch/arm/kernel/head-common.S | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/kernel/head-common.S b/arch/arm/kernel/head-common.S
index 5b391a6..1fb887d 100644
--- a/arch/arm/kernel/head-common.S
+++ b/arch/arm/kernel/head-common.S
@@ -133,6 +133,8 @@ ENTRY(lookup_processor_type)
ldmfd sp!, {r4 - r6, r9, pc}
ENDPROC(lookup_processor_type)
+ __FINIT
+
/*
* Read processor ID register (CP#15, CR0), and look up in the linker-built
* supported processor list. Note that we can't use the absolute addresses
--
1.8.1.5
More information about the linux-arm-kernel
mailing list