[RFC] Add .dts file for Netgear ReadyNAS 102
Arnaud Ebalard
arno at natisbad.org
Tue Jul 2 19:27:31 EDT 2013
Hi,
Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com> writes:
>> + pinctrl {
>> + power_led_pin: power-led-pin {
>> + marvell,pins = "mpp57";
>> + marvell,function = "gpio";
>> + };
>> + sata1_led_pin: sata1-led-pin {
>> + marvell,pins = "mpp15";
>> + marvell,function = "gpio";
>> + };
>> +
>> + sata2_led_pin: sata2-led-pin {
>> + marvell,pins = "mpp14";
>> + marvell,function = "gpio";
>> + };
>> +
>> + backup_led_pin: backup-led-pin {
>> + marvell,pins = "mpp56";
>> + marvell,function = "gpio";
>> + };
>> + };
>> +
>> + gpio_leds {
>
> Arnaud,
>
> gpio_leds, gpio_keys, and clocks nodes shouldn't be children of
> soc/internal-regs. I suggest to move them up as siblings of soc,
> memory, and chosen instead.
Will do that in next round. Thanks for pointing it.
Cheers,
a+
More information about the linux-arm-kernel
mailing list