[PATCH v2 1/2] drivers: net: cpsw: Add helper functions for VLAN ALE implementation

Francois Romieu romieu at fr.zoreil.com
Thu Jan 31 16:43:06 EST 2013


Mugunthan V N <mugunthanvnm at ti.com> :
> On 1/31/2013 3:32 AM, Francois Romieu wrote:
[...]
> > It could be factored out.
> Are you mentioning to have static inline function for the above two
> statements above?

Yes. The helper function does not need to be inlined if it does not
save space: this path is not performance critical.

[...]
> >Patch #2 doesn't use the returned status code.
> Will modify the prototype to return void

:o(

The driver should notify the upper layers that the request failed instead
of hiding the stuff under the carpet.

-- 
Ueimor



More information about the linux-arm-kernel mailing list