[PATCH 05/10] gpio: pxa: remove gpio_type

[Linus Walleij]

On Mon, Jan 28, 2013 at 12:29 PM, Igor Grinberg <grinberg at compulab.co.il> wrote:
> On 01/25/13 12:01, Linus Walleij wrote:
>> On Wed, Jan 23, 2013 at 9:25 AM, Haojian Zhuang
>> <haojian.zhuang at linaro.org> wrote:
>>
>>> Since gpio_type is used to check whether gafr register is valid. So
>>> move it into platform data.
>>>
>>> Signed-off-by: Haojian Zhuang <haojian.zhuang at linaro.org>
>>
>> (...)
>>
>>> +++ b/drivers/gpio/gpio-pxa.c
>>> @@ -72,6 +72,7 @@ struct pxa_gpio_chip {
>>>         void __iomem    *regbase;
>>>         unsigned int    irq_base;
>>>         unsigned int    inverted;
>>> +       unsigned int    gafr;
>>>         char label[10];
>>
>> Also looks like some kind of a bool.
>
> Actually, no... GAFR is the PXA Alternate Function register name,
> so unsigned int (or u32) is good.

Alternate funtion register?

Thanks for telling!

So this is about muxing and should thus be in the pinctrl
framework?

Or is there some criss-cross with pinctrl already that I'm
not aware of?

Yours,
Linus Walleij