[PATCH v2 1/2] ARM: kirkwood: Ensure that kirkwood_ge0[01]_init() finds its clock

Jason Cooper jason at lakedaemon.net
Wed Jan 30 19:32:22 EST 2013


On Thu, Jan 31, 2013 at 12:22:24AM +0100, Sebastian Hesselbarth wrote:
> On 01/31/2013 12:01 AM, Jason Cooper wrote:
> >As it stands, there are three patches to fix this issue:
> >
> >ARM: kirkwood: of_serial: fix clock gating by removing clock-frequency
> >ARM: kirkwood: provide ge clock aliases for shared smi
> >ARM: kirkwood: fix to retain gbe MAC addresses for DT kernels
> 
> Actually, for the second patch I got distracted by the smi split patch
> set floating around. But that is not in current kernel and smi will not
> request any clock at all.
> 
> If Simon can hit another round of testing without second patch included
> and agrees, I suggest to keep it for next release.

Ok, I'll wait for Simon on this.  fixes can go anytime, so no rush.
Better to get it right the first (second?) time out.

> >wrt to ge losing mac addresses, both DT and non-DT booting are covered by
> >Sebastian's patches, for non-DT aware mv643xx_eth.
> 
> non-DT already ungates ge0/1 clocks on registration and cannot loose its
> mac address, not my fix.

Yes, bad wording on my part.  I meant that everything was magically
fixed by Sebastian and that his thesis should be approved without
challenge.  ;-)

thx,

Jason.



More information about the linux-arm-kernel mailing list