[PATCH v2 1/2] ARM: kirkwood: Ensure that kirkwood_ge0[01]_init() finds its clock
Jason Gunthorpe
jgunthorpe at obsidianresearch.com
Wed Jan 30 18:05:18 EST 2013
On Wed, Jan 30, 2013 at 05:43:00PM -0500, Jason Cooper wrote:
> > On 01/29/2013 09:32 PM, Jason Cooper wrote:
> > >On Tue, Jan 29, 2013 at 09:08:46PM +0100, Sebastian Hesselbarth wrote:
> > >>Leaves Issue 3, gbe forgets about its MAC address when gated or powered
> > >>down. That should be done with local-mac-address passed by DT enabled
> > >>u-boot or any other (dirty) ATAG hack ;)
> > >
> > >A patch to mv643xx_eth to pull this from DT should solve this.
>
> Somewhere, Jason Gunthorpe shared his patch to do this. I'll poke
> around for it and try to get it merged in.
Yes, you asked for the doc update and I haven't had a moment to get a
tree setup for that..
Here are some words though:
- local-mac-address : Optional, the MAC address to assign to the
device. If not specified then the MAC address in the HW
registers is used, but the driver can not be made modular.
diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/ethernet/marvell/mv643xx_eth.c
index 7048d7c..2b2cfcb 100644
--- a/drivers/net/ethernet/marvell/mv643xx_eth.c
+++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
@@ -2891,6 +2891,8 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
struct mv643xx_eth_private *mp;
struct net_device *dev;
struct resource *res;
+ const u8 *mac;
+ int len;
int err;
if (pdev->dev.of_node) {
@@ -2912,6 +2914,10 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
else
pd->phy_addr = MV643XX_ETH_PHY_ADDR_DEFAULT;
+ mac = of_get_property(pdev->dev.of_node, "local-mac-address", &len);
+ if (mac && len == 6)
+ memcpy(pd->mac_addr, mac, sizeof pd->mac_addr);
+
np = of_parse_phandle(pdev->dev.of_node, "mdio", 0);
if (np) {
pd->shared = of_find_device_by_node(np);
--
1.7.5.4
More information about the linux-arm-kernel
mailing list