[PATCH 1/2] ARM: memory: use SZ_ constants for defining the virtual memory layout
Matt Sealey
matt at genesi-usa.com
Wed Jan 30 15:41:40 EST 2013
On Wed, Jan 30, 2013 at 8:08 AM, Will Deacon <will.deacon at arm.com> wrote:
> Parts of the virtual memory layout (mainly the modules area) are
> described using open-coded immediate values.
>
> Use the SZ_ definitions from linux/sizes.h instead to make the code
> clearer.
>
> Signed-off-by: Will Deacon <will.deacon at arm.com>
> ---
> arch/arm/include/asm/memory.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
> index 73cf03a..a0fd518 100644
> --- a/arch/arm/include/asm/memory.h
> +++ b/arch/arm/include/asm/memory.h
> @@ -36,23 +36,23 @@
> * TASK_UNMAPPED_BASE - the lower boundary of the mmap VM area
> */
> #define PAGE_OFFSET UL(CONFIG_PAGE_OFFSET)
> -#define TASK_SIZE (UL(CONFIG_PAGE_OFFSET) - UL(0x01000000))
> +#define TASK_SIZE (UL(CONFIG_PAGE_OFFSET) - UL(SZ_16M))
> #define TASK_UNMAPPED_BASE (UL(CONFIG_PAGE_OFFSET) / 3)
>
> /*
> * The maximum size of a 26-bit user space task.
> */
> -#define TASK_SIZE_26 UL(0x04000000)
> +#define TASK_SIZE_26 UL(SZ_64M)
Wouldn't this make far more sense as UL(1<<26) ?
--
Matt Sealey <matt at genesi-usa.com>
Product Development Analyst, Genesi USA, Inc.
More information about the linux-arm-kernel
mailing list