[RFC 3/3] arm: mach-mxs: make enabling enet_out a legacy function
shawn.guo at linaro.org
Wed Jan 30 07:29:33 EST 2013
On Wed, Jan 30, 2013 at 08:58:32AM +0100, Wolfram Sang wrote:
> On Wed, Jan 30, 2013 at 01:48:40PM +0800, Shawn Guo wrote:
> > On Tue, Jan 29, 2013 at 03:46:13PM +0100, Wolfram Sang wrote:
> > > @@ -351,7 +359,7 @@ static void __init tx28_post_init(void)
> > > struct pinctrl *pctl;
> > > int ret;
> > >
> > > - enable_clk_enet_out();
> > > + legacy_enable_clk_enet_out();
> > I think TX28 is the only case that really needs to turn on enet_out
> > clock at platform level, since it has some dirty work about PHY to do
> > here. With with fec driver handling the clock, enable_clk_enet_out()
> > can just be removed for other boards.
> I would love to, but this will cause regression on boards which update
> the kernel but not the devicetree (no third clock), or?
Ah, that's the consideration. When someday arch/arm/boot/dts gets
maintained outside kernel tree, we may be required to keep devicetree
compatibility to different kernel versions. But we haven't got there
yet. Today people are supposed to use devicetree matching kernel.
More information about the linux-arm-kernel