[RESEND PATCH v5 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect
alexander.shishkin at linux.intel.com
Wed Jan 30 05:31:04 EST 2013
Peter Chen <peter.chen at freescale.com> writes:
> On Wed, Jan 30, 2013 at 11:36:42AM +0530, kishon wrote:
>> > bool global_phy;
>> > struct usb_phy *transceiver;
>> > struct usb_hcd *hcd;
>> >- struct usb_otg otg;
>> >+ struct usb_otg otg;
>> You have added *otg* in previous patch and added a tab for *otg* in
>> this patch.
> thanks, I will change at previous patch
>> >+#define CI_VBUS_STABLE_TIMEOUT 500
>> Just curious.. how was this timeout value obtained?
> Just a timeout value, if the vbus goes to required value, it will quit.
> Besides, 5s for vbus stable should be enough for an well behaviour hardware.
Can you also mention this in the patch, since it raises questions?
More information about the linux-arm-kernel