[PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type
Marc Kleine-Budde
mkl at pengutronix.de
Tue Jan 29 10:05:44 EST 2013
On 01/29/2013 03:55 PM, Wolfram Sang wrote:
>
>> I prefer u32 here, because we have the matching enum. Otherwise we end
>> up with:
>>
>> of_property_read_string(...,&type);
>>
>> if (!strcmp(type, "ulpi"))
>> foo();
>> else if (!strcmp(type, "utmi"))
>> bar();
>> else if (!strcmp(type, "pipe3"))
>> baz();
>> else
>> BUG();
>>
>> and I don't like that, it's ugly and error prone.
>
> Error prone? I guess my mileage varies. Especially compared to the
> probability devicetree creators pick the wrong number.
>
> It also removes the (probably implicit) rule that the enum mustn't be
> modified since it is exported to users.
>
> Also, you could map the strings to the enum first and then switch-case
> over it to make the code nicer.
That's what the code already does.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130129/f33d6864/attachment.sig>
More information about the linux-arm-kernel
mailing list