[PATCH] ARM:common: setting saved_state to NULL after kfree

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Jan 29 06:15:26 EST 2013


On Tue, Jan 29, 2013 at 07:11:43PM +0800, Chen Gang wrote:
>   need set NULL before return, just like function sa1111_remove has done.
>   and better to use sa1111_remove directly, instead of current implementation.

NAK.

1. __sa1111_remove() will kfree sachip, so the value of sachip->saved_state
   at this point is meaningless.
2. I don't think you tried to build with your patch in place.



More information about the linux-arm-kernel mailing list