[PATCH 3/4] watchdog: add support for ux500_wdt watchdog
fabio.baltieri at linaro.org
Tue Jan 29 03:43:13 EST 2013
thanks for the review!
On Mon, Jan 28, 2013 at 10:12:22PM +0100, Wim Van Sebroeck wrote:
> > +static int timeout = WATCHDOG_TIMEOUT;
> > +module_param(timeout, int, 0);
> > +MODULE_PARM_DESC(timeout,
> > + "Watchdog timeout in seconds. default="
> > + __MODULE_STRING(WATCHDOG_TIMEOUT) ".");
> We should go for unsigned int timeout values...
You're right! This ends up in an unsigned on the rest of the code
anyway and I see other drivers using it as unsigned so I'll change it in
v2 (here and in ux500_wdt_data).
> > +static int nowayout = WATCHDOG_NOWAYOUT;
> > +module_param(nowayout, int, 0);
> > +MODULE_PARM_DESC(nowayout,
> > + "Watchdog cannot be stopped once started (default="
> > + __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> nowayout is a boolean value so please change this to
> static bool nowayout = WATCHDOG_NOWAYOUT;
> The rest is OK by me. So if bowayout get's fixed then you have my acked-by.
Ok, I'll send a v2 of this patch soon with both parameters fixed for you
More information about the linux-arm-kernel