[GIT PULL] imx cleanup for 3.9

Sascha Hauer s.hauer at pengutronix.de
Tue Jan 29 02:26:03 EST 2013


On Tue, Jan 29, 2013 at 09:08:55AM +0800, Shawn Guo wrote:
> On Mon, Jan 28, 2013 at 02:00:26PM -0800, Olof Johansson wrote:
> > Hi,
> > 
> > On Tue, Jan 22, 2013 at 10:48:15PM +0800, Shawn Guo wrote:
> > 
> > > Shawn Guo (4):
> > >       ARM: dts: imx: use nodes label in board dts
> > 
> > Hmm.
> > 
> > This patch is 1000 lines of pure churn. Sure, the style on OMAP is different,
> > but there's no clear benefit from it -- it's actually advantageous to see some
> > of the bus hierarchies even on the leaf-level board nodes.
> > 
> > Would you mind respinning with this left out, please? If you still want to
> > argue it to be included, we can do so, but I'd like to pick up the rest of the
> > branch meanwhile. :-)
> 
> I will refresh the pull-request to leave it out, but meanwhile I'd like
> to argue too, as the approach has been agreed by IMX people and all the
> patches I queued on imx/dt are all in this way.  And I will move the
> patch to imx/dt branch instead, if you're not strongly against the
> approach.
> 
> The board level dts are mostly used to add/overwrite properties for
> nodes defined in soc dts.  Therefore, what people who look at board
> dts care about is those properties, not really which bus the nodes
> are on.  We go this way to have board dts focus on the things they
> are created for.  It's much easer to read and edit those properties.
> 
> I'm not sure why it's important to maintain the bus topology in board
> dts while we have the full one in soc dts.  In the current way, people
> sometimes have to reassemble 3 or more levels bus hierarchies for only
> overwriting one property for one node.  
> 
> I'm pretty sure that people who work on board level dts would vote for
> this way.  It makes their life easier without increasing the
> maintainer's burden.  So why not?

I'm with Shawn here. With this board layout I'm now able to write board
dts files without looking much at the dtsi file at all. It's debatable
if existing boards have to be changed to use this layout, but since
people copy-paste all the time changing it increases the chance they
copy the right stuff.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the linux-arm-kernel mailing list