[PATCH v6 1/2] ARM: davinci: Remoteproc driver support for OMAP-L138 DSP

Tivy, Robert rtivy at ti.com
Mon Jan 28 18:56:10 EST 2013


> -----Original Message-----
> From: Sergei Shtylyov [mailto:sshtylyov at mvista.com]
> Sent: Saturday, January 26, 2013 7:22 AM
> 
> Hello.
> 
> On 26-01-2013 6:45, Robert Tivy wrote:
> 
> > Adding a remoteproc driver implementation for OMAP-L138 DSP
> 
> > diff --git a/drivers/remoteproc/da8xx_remoteproc.c
> b/drivers/remoteproc/da8xx_remoteproc.c
> > new file mode 100644
> > index 0000000..c6eb6bf
> > --- /dev/null
> > +++ b/drivers/remoteproc/da8xx_remoteproc.c
> > @@ -0,0 +1,327 @@
> [...]
> > +#define SYSCFG_CHIPSIG_OFFSET 0x174
> > +#define SYSCFG_CHIPSIG_CLR_OFFSET 0x178
> 
>     Wait, you don't even use these #define's -- why they're here at
> all?
> 
> WBR, Sergei

I will remove those.  They were inadvertently left over from when the driver was mapping SYSCFG0's base address and using those offsets to get to the CHIPSIG registers.

Regards,

- Rob





More information about the linux-arm-kernel mailing list