[PATCH V3 8/8] ARM: kirkwood: mv643xx_eth dt conversion

Andrew Lunn andrew at lunn.ch
Sat Jan 26 07:38:27 EST 2013


> diff --git a/arch/arm/mach-kirkwood/board-dt.c b/arch/arm/mach-kirkwood/board-dt.c
> index 73b76e4..7ab92e5 100644
> --- a/arch/arm/mach-kirkwood/board-dt.c
> +++ b/arch/arm/mach-kirkwood/board-dt.c
> @@ -48,7 +48,7 @@ static void __init kirkwood_legacy_clk_init(void)
>  	clkspec.args_count = 1;
>  
>  	clkspec.args[0] = CGC_BIT_GE0;
> -	orion_clkdev_add(NULL, "mv643xx_eth_port.0",
> +	orion_clkdev_add(NULL, "f1072000.egiga0",
>  			 of_clk_get_from_provider(&clkspec));
>  
>  	clkspec.args[0] = CGC_BIT_PEX0;
> @@ -60,7 +60,7 @@ static void __init kirkwood_legacy_clk_init(void)
>  			 of_clk_get_from_provider(&clkspec));
>  
>  	clkspec.args[0] = CGC_BIT_GE1;
> -	orion_clkdev_add(NULL, "mv643xx_eth_port.1",
> +	orion_clkdev_add(NULL, "f1076000.egiga1",
>  			 of_clk_get_from_provider(&clkspec));
>  }
>  

Hi Jason

These changes break any platform not yet converted, eg my QNAP box now
locks up solid.

Something is not right here, or i'm not understanding something. DT
devices should not need code like this, only devices not yet using
DT....

	Andrew



More information about the linux-arm-kernel mailing list