[PATCHv1 for soc 4/5] arm: Add v7_invalidate_l1 to cache-v7.S
Pavel Machek
pavel at denx.de
Fri Jan 25 13:05:25 EST 2013
On Fri 2013-01-25 10:24:17, Dinh Nguyen wrote:
> Hi Pavel,
> On Fri, 2013-01-25 at 16:49 +0100, Pavel Machek wrote:
> > Hi!
> >
> > > mach-socfpga is another platform that needs to use
> > > v7_invalidate_l1 to bringup additional cores. There was a comment that
> > > the ideal place for v7_invalidate_l1 should be in arm/mm/cache-v7.S
> >
> > If there are three copies of code, with fourth one needed for next
> > platform, moving it into common code makes sense.
> >
> > But... The code was not identical before the merge. Are you sure that
> > the differences do not hurt? At the very least, it should be mentioned
> > in the changelog.
>
> Indeed, the addition of
>
> mcr p15, 0, r0, c7, c5, 0 @ invalidate I cache
>
> was done by commit # 5b2acf384c8a8707d32a98106192ee7187e4446d
>
> This adds invalidate I-Cache as well as D-Cache, which I think should be
> ok for most platforms.
>
> Hopefully, Stephen can test and verify.
Otherwise it works for me... and looks like a good idea.
Tested-by: Pavel Machek <pavel at denx.de>
Reviewed-by: Pavel Machek <pavel at denx.de>
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
More information about the linux-arm-kernel
mailing list