[PATCH 04/10] gpio: pxa: use platform data for gpio inverted

Linus Walleij linus.walleij at linaro.org
Fri Jan 25 04:59:49 EST 2013


On Wed, Jan 23, 2013 at 9:25 AM, Haojian Zhuang
<haojian.zhuang at linaro.org> wrote:

> Avoid to judge whether gpio is inverted by identifying cpu in gpio
> driver. Move this into platform data of gpio driver.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang at linaro.org>

(...)
> +++ b/drivers/gpio/gpio-pxa.c
> @@ -71,6 +71,7 @@ struct pxa_gpio_chip {
>         struct gpio_chip chip;
>         void __iomem    *regbase;
>         unsigned int    irq_base;
> +       unsigned int    inverted;
>         char label[10];

I would use bool for this.

(No big deal, but if you want to nitpick..)

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list