[PATCH 1/2 net-next] net: fec: add napi support to improve proformance

Frank Li lznuaa at gmail.com
Wed Jan 23 02:44:53 EST 2013


> This comment seems rather unnecessary. Also it should be
>
>         /* space left and right /*
>
> devicetree bindings should use '-' instead of '_'. The binding
> Documentation should be in the patch adding the bindings. Also
> make sure the devicetree parsing is outside of the path for platform
> based probing.
>
> With this particular binding I'm unsure it should exist anyway since
> it's configuration rather than hardware description. The devicetree
> normally is for hardware description only.
>

What's your opinion?
Using module parameter, device-tree to config it or the other method?

best regards
Frank Li



More information about the linux-arm-kernel mailing list