[PATCH 1/4] ARM: cache-l2x0: Manage the errata at run time

Will Deacon will.deacon at arm.com
Tue Jan 22 12:05:01 EST 2013


On Tue, Jan 22, 2013 at 05:42:29AM +0000, Srinidhi Kasagar wrote:
> On Mon, Jan 21, 2013 at 15:03:44 +0100, Will Deacon wrote:
> > On Mon, Jan 21, 2013 at 01:14:53PM +0000, srinidhi kasagar wrote:
> > > +asmlinkage u32 l2x0_get_rtl_release(void)
> > > +{
> > > +	return readl_relaxed(l2x0_base + L2X0_CACHE_ID) &
> > > +			L2X0_CACHE_ID_RTL_MASK;
> > > +}
> > 
> > You're calling this function all over the place, including from the flush
> > code. Can you read the RTL release during probe and stash it somewhere
> > instead please?
> 
> I thought of doing that, however TI omap's suspend is the only one which needs
> this API as well, So, I had to make it global. Refer my patch 3/4. I can
> duplicate this for omap if you think so..

Just make the get_rtl_release_function return the stashed value if it's been
probed and get the driver to use the stashed value directly.

Will



More information about the linux-arm-kernel mailing list