[RFC v2 16/18] ARM: OMAP2+: AM33XX: Basic suspend resume support
Peter Korsgaard
jacmet at sunsite.dk
Tue Jan 22 07:50:15 EST 2013
>>>>> "V" == Bedia, Vaibhav <vaibhav.bedia at ti.com> writes:
Hi,
V> + memcpy((void *)wkup_m3_context->code, fw->data, fw->size);
>>
>> A size check would be good. I don't know much about the finer details
>> about the m3 and how it is connected, but don't you need to ensure data
>> is flushed before resetting the m3?
>>
V> Will add the reg property in the next version. The wkup-m3 memory is
V> coming via ioremap() so AFAIK it should be ok. I realized that I do
V> need to replace the memcpy() with memcpy_toio() here.
Ok, thanks.
--
Bye, Peter Korsgaard
More information about the linux-arm-kernel
mailing list